Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable checksum offload on the VXLAN tunnel for kernels <v5.7. #2811

Merged
merged 6 commits into from
May 18, 2021
Merged

Disable checksum offload on the VXLAN tunnel for kernels <v5.7. #2811

merged 6 commits into from
May 18, 2021

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented May 14, 2021 •
edited

Description

The combination of iptables MASQUERADE --random-fully and such kernels results in broken checksum calculations.

Fixes projectcalico/calico#3145

Todos

  • Unit tests (full coverage)
  • Integration tests (delete as appropriate) In plan/Not needed/Done
  • Documentation
  • Backport
  • Release note

Release Note

Disable VXLAN tunnel checksum offload on kernels <v5.7.  Works around https://github.com/projectcalico/calico/issues/3145.

@marvin-tigera marvin-tigera added this to the Calico v3.20.0 milestone May 14, 2021
@fasaxc fasaxc marked this pull request as ready for review May 14, 2021 14:08
@fasaxc fasaxc requested a review from a team as a code owner May 14, 2021 14:08
nelljerram
nelljerram approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@nelljerram nelljerram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

caseydavenport
caseydavenport reviewed May 14, 2021
View reviewed changes
Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fasaxc
Reduce FV verbosity:
2fff0dc 
Ignore infra logs during stop.
Log command output inline rather than buffer.
@fasaxc
Markups: fine tune command output.
6c88ebb
@fasaxc
Disable checksum offload on the VXLAN tunnel for kernels <v5.7.
5e86f1d 
The combination of iptables MASQUERADE --random-fully and such
kernels results in broken checksum calculations.
@fasaxc
Add VXLAN checksum FV, fix feature detect override.
24c2930 
Use reflection to access the feature fields to avoid needing
code or every field.
@fasaxc
Add extra diags and remove no-op.
c334f05
@fasaxc
Pre-load ipip kernel module to prevent flake.
0e3e12e
@fasaxc
Copy link
Member Author

fasaxc commented May 18, 2021

/merge-when-ready

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.

@marvin-tigera marvin-tigera merged commit 31a1f2a into projectcalico:master May 18, 2021
fasaxc pushed a commit to fasaxc/felix that referenced this pull request May 18, 2021
@marvin-tigera @fasaxc
Merge pull request projectcalico#2811 from fasaxc/vxlan-checksum
063df63 
Disable checksum offload on the VXLAN tunnel for kernels <v5.7.
@fasaxc fasaxc mentioned this pull request May 18, 2021
Merged
5 tasks
This was referenced Jun 9, 2021
Merged
Closed
@CecileRobertMichon CecileRobertMichon mentioned this pull request Aug 4, 2021
Merged
3 tasks
@manuelbuil manuelbuil mentioned this pull request Aug 9, 2021
Closed
@champtar
Copy link

This disable VXLAN offload for RHEL/CentOS 8.x that is supposed to be fixed, any plan to improve the detection ?

@rgl rgl mentioned this pull request Aug 26, 2021
Closed
@cyclinder cyclinder mentioned this pull request Jun 20, 2023
Closed
@cyclinder cyclinder mentioned this pull request Sep 19, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport left review comments

@nelljerram nelljerram nelljerram approved these changes

Assignees
No one assigned
Labels
docs-not-required merge-when-ready release-note-required
Projects
None yet
Milestone
Calico v3.20.0
5 participants
@fasaxc @marvin-tigera @champtar @caseydavenport @nelljerram